Jump to content
Larry Ullman's Book Forums

Recommended Posts

I believe there is an error in the book regarding uploads and the temporary file created when performing uploads.

Regarding uploads, Larry writes in Chapter 11:

"If the file was uploaded but it could not be moved to its final destination or some other error occurred, then that file is still sitting on the server in its temporary location."

However, the PHP manual states:

"The file will be deleted from the temporary directory at the end of the request if it has not been moved away or renamed."

Source: https://secure.php.net/manual/en/features.file-upload.post-method.php

In studying the upload process, I removed the code in upload_image.php that calls move_uploaded_file() and just dumped the upload info to confirm that the request went through without errors.

I searched my entire system for the file (starting with the location I set in upload_tmp_dir of course, and confirming that all users had write access to the folder) but it was not found, proving that the file is removed at the end of the request.

 

When I added the code back to move the file to a permanent location via move_uploaded_file, the file was moved to the permanent location as expected.  

So it seems that move_uploaded_file() is *required* to be used when uploading a file if you want to save whatever was uploaded.  

I am running PHP 7.1.7 via XAMPP on Windows 10 and got the same results on Chrome and Firefox.

 

A modified upload_image.php script is below that you can run yourself. Let me know if anyone gets a different result or I am incorrect in what I wrote above. Thanks!

<!doctype html>

<html lang="en">

<head>

    <meta charset="utf-8">

    <title>Upload an Image</title>

</head>

<body>

<?php

// Check if the form has been submitted:

if ($_SERVER['REQUEST_METHOD'] == 'POST') {

    // Check for an uploaded file:

    if (isset($_FILES['upload'])) {

        echo "<pre>";

        var_dump($_FILES);

        echo "</pre>";     

    }

} // End of the submitted conditional.

?>



<form enctype="multipart/form-data" action="upload_image.php" method="post">



    <input type="hidden" name="MAX_FILE_SIZE" value="128000000">



    <fieldset>

    <p><strong>File:</strong> <input type="file" name="upload"></p>

    </fieldset>

    <div align="center"><input type="submit" name="submit" value="Submit"></div>



</form>

</body>

</html>

Share this post


Link to post
Share on other sites

Ah, interesting. They must have changed this in PHP. Thanks for reporting! I'll get that resolved. 

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×